Add instructions and processor for stake deactivate and withdraw #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-solana
reviewed
Jun 21, 2019
| /// | ||
| /// Expects 1 Accounts: | ||
| /// 0 - Delegate StakeAccount | ||
| Deactivate, |
rob-solana
reviewed
Jun 21, 2019
| /// Deactivates the stake in the account | ||
| /// | ||
| /// Expects 1 Accounts: | ||
| /// 0 - Delegate StakeAccount |
There was a problem hiding this comment.
need 2: the delegate and syscall::current
rob-solana
reviewed
Jun 21, 2019
| if rest.len() != 0 { | ||
| Err(InstructionError::InvalidInstructionData)?; | ||
| } | ||
| me.deactivate_stake(&syscall::current::from_keyed_account(&me)?) |
There was a problem hiding this comment.
rest.len() should be exactly 1 and current comes from &rest[0]
rob-solana
reviewed
Jun 21, 2019
| }; | ||
| if lamports > self.account.lamports.saturating_sub(staked) { | ||
| return Err(InstructionError::InsufficientFunds); | ||
| } |
There was a problem hiding this comment.
I think we should also lower stake.stake to whatever remains in the account
rob-solana
reviewed
Jun 21, 2019
| @@ -284,6 +277,41 @@ mod tests { | |||
| ), | |||
| Err(InstructionError::InvalidAccountData), | |||
| ); | |||
|
|
|||
| // gets the deserialization checks in deactivate | |||
There was a problem hiding this comment.
make sure comments are correct
rob-solana
force-pushed
the
move-redemption-to-rewards-pools
branch
from
dcfc8da to
38ce28a
Compare
|
these can land on master now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing instruction for deactivating stake
Summary of Changes
Added code and tests
solana-labs#4357